Differential D21437

Make "Quote" work properly in Pholio
ClosedPublic
Actions

Authored by epriestley on Aug 10 2020, 8:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 3:19 PM

	Unknown Object (File)
	Wed, Dec 18, 2:08 AM

	Unknown Object (File)
	Mon, Dec 16, 4:14 AM

	Unknown Object (File)
	Sat, Dec 14, 9:48 AM

	Unknown Object (File)
	Thu, Dec 12, 7:15 PM

	Unknown Object (File)
	Sat, Dec 7, 3:14 PM

	Unknown Object (File)
	Sat, Dec 7, 12:56 PM

	Unknown Object (File)
	Thu, Dec 5, 4:37 AM

Subscribers

None

Details

Reviewers: None
Commits: rP79375c6c5398: Make "Quote" work properly in Pholio

Summary

See https://discourse.phabricator-community.org/t/quote-comment-missing-on-mock-pages/4155. Pholio is currently missing a couple of configuration calls to make the "Quote" action work.

Moving to EditEngine is the "real" fix, but this fix is trivial and should make "Quote" work properly with no negative effects.

Test Plan

Viewed a mock, used "quote" to quote a comment.

Diff Detail

Repository

Branch

pholio1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24828
Build 34254: Run Core Tests
Build 34253: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 10 2020, 8:31 PM

Harbormaster completed remote builds in B24828: Diff 51010.Aug 10 2020, 8:32 PM

epriestley requested review of this revision.Aug 10 2020, 8:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 10 2020, 8:40 PM

Closed by commit rP79375c6c5398: Make "Quote" work properly in Pholio (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP79375c6c5398: Make "Quote" work properly in Pholio.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

controller/

PholioMockViewController.php

3 lines

Diff 51010

src/applications/pholio/controller/PholioMockViewController.php

Loading...