Page MenuHomePhabricator

Make "Quote" work properly in Pholio
ClosedPublic

Authored by epriestley on Aug 10 2020, 8:31 PM.
Tags
None
Referenced Files
F15535495: D21437.id51011.diff
Thu, Apr 24, 5:27 AM
F15455469: D21437.id51010.diff
Sun, Mar 30, 12:39 AM
F15454450: D21437.id51011.diff
Sat, Mar 29, 6:34 PM
F15451610: D21437.id.diff
Mar 28 2025, 10:58 PM
F15444200: D21437.diff
Mar 27 2025, 8:25 AM
F15440373: D21437.diff
Mar 26 2025, 12:28 PM
F15395404: D21437.id51010.diff
Mar 16 2025, 6:44 AM
F15392404: D21437.id51011.diff
Mar 15 2025, 2:59 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/quote-comment-missing-on-mock-pages/4155. Pholio is currently missing a couple of configuration calls to make the "Quote" action work.

Moving to EditEngine is the "real" fix, but this fix is trivial and should make "Quote" work properly with no negative effects.

Test Plan

Viewed a mock, used "quote" to quote a comment.

Diff Detail

Repository
rP Phabricator
Branch
pholio1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24828
Build 34254: Run Core Tests
Build 34253: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 10 2020, 8:40 PM
This revision was automatically updated to reflect the committed changes.