Page MenuHomePhabricator

Remove ancient "phd.trace" and "phd.verbose" configuration options
ClosedPublic

Authored by epriestley on Jul 23 2020, 7:22 PM.
Tags
None
Referenced Files
F15336574: D21426.diff
Sat, Mar 8, 7:39 PM
F15331402: D21426.diff
Fri, Mar 7, 10:06 AM
Unknown Object (File)
Wed, Feb 19, 9:07 AM
Unknown Object (File)
Feb 17 2025, 12:58 AM
Unknown Object (File)
Feb 16 2025, 7:57 AM
Unknown Object (File)
Feb 11 2025, 4:47 AM
Unknown Object (File)
Feb 9 2025, 9:48 AM
Unknown Object (File)
Feb 9 2025, 9:48 AM
Subscribers
None

Details

Summary

Ref T13556. These options are very old and effectively obsoleted by "bin/phd debug [--trace]". I haven't used either option diagnostically in many years, and they aren't mentioned in the documentation.

Remove them to simplify configuration, and because "phd.trace" doesn't work anyway and likely hasn't for a long time -- it has specific issues with TTY detection (see T13556).

Test Plan

Grepped for "phd.trace" and "phd.verbose". Ran "bin/phd debug [--trace]" and saw verbose/trace output.

Diff Detail

Repository
rP Phabricator
Branch
trace1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24803
Build 34219: Run Core Tests
Build 34218: arc lint + arc unit