Page MenuHomePhabricator

Remove ancient "phd.trace" and "phd.verbose" configuration options
ClosedPublic

Authored by epriestley on Jul 23 2020, 7:22 PM.
Tags
None
Referenced Files
F15482066: D21426.id50984.diff
Wed, Apr 9, 2:36 AM
F15478813: D21426.id50982.diff
Tue, Apr 8, 2:58 AM
F15471120: D21426.id50982.diff
Sat, Apr 5, 3:22 AM
F15468039: D21426.id.diff
Thu, Apr 3, 7:39 PM
F15466680: D21426.id50983.diff
Thu, Apr 3, 8:14 AM
F15465515: D21426.diff
Wed, Apr 2, 7:47 PM
F15462488: D21426.diff
Tue, Apr 1, 3:23 PM
F15443023: D21426.diff
Thu, Mar 27, 1:43 AM
Subscribers
None

Details

Summary

Ref T13556. These options are very old and effectively obsoleted by "bin/phd debug [--trace]". I haven't used either option diagnostically in many years, and they aren't mentioned in the documentation.

Remove them to simplify configuration, and because "phd.trace" doesn't work anyway and likely hasn't for a long time -- it has specific issues with TTY detection (see T13556).

Test Plan

Grepped for "phd.trace" and "phd.verbose". Ran "bin/phd debug [--trace]" and saw verbose/trace output.

Diff Detail

Repository
rP Phabricator
Branch
trace1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24802
Build 34217: Run Core Tests
Build 34216: arc lint + arc unit