Page MenuHomePhabricator

Remove ancient "phd.trace" and "phd.verbose" configuration options
ClosedPublic

Authored by epriestley on Jul 23 2020, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 10:54 PM
Unknown Object (File)
Fri, Nov 22, 4:13 PM
Unknown Object (File)
Thu, Nov 21, 9:10 AM
Unknown Object (File)
Thu, Nov 14, 6:51 AM
Unknown Object (File)
Wed, Nov 13, 7:30 AM
Unknown Object (File)
Mon, Nov 11, 2:58 AM
Unknown Object (File)
Thu, Nov 7, 11:07 AM
Unknown Object (File)
Mon, Nov 4, 11:00 PM
Subscribers
None

Details

Summary

Ref T13556. These options are very old and effectively obsoleted by "bin/phd debug [--trace]". I haven't used either option diagnostically in many years, and they aren't mentioned in the documentation.

Remove them to simplify configuration, and because "phd.trace" doesn't work anyway and likely hasn't for a long time -- it has specific issues with TTY detection (see T13556).

Test Plan

Grepped for "phd.trace" and "phd.verbose". Ran "bin/phd debug [--trace]" and saw verbose/trace output.

Diff Detail

Repository
rP Phabricator
Branch
trace1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24802
Build 34217: Run Core Tests
Build 34216: arc lint + arc unit