Page MenuHomePhabricator
Differential D21417

Unify more build, property, auditor, and status information into "CommitGraphView"
ClosedPublic
Actions

Authored by epriestley on Jul 12 2020, 7:45 PM.
Tags
None
Referenced Files
F19218725: D21417.diff
Wed, Dec 17, 9:24 AM
F19083364: D21417.id51034.diff
Tue, Dec 2, 12:34 PM
F19015798: D21417.id51034.diff
Sun, Nov 23, 1:45 AM
F19011996: D21417.id.diff
Sat, Nov 22, 11:46 AM
F18993541: D21417.id50962.diff
Wed, Nov 19, 8:10 AM
F18903231: D21417.diff
Nov 8 2025, 4:30 AM
F18837315: D21417.diff
Oct 27 2025, 4:53 AM
F18788341: D21417.id50962.diff
Oct 15 2025, 4:25 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP8aec3f916b39: Unify more build, property, auditor, and status information into…
Summary

Ref T13552. In unifying the various Graph/List/Table commit views, some information was dropped -- particularly, audit status.

Restore most of it. The result isn't very pretty, but has most of the required information.

Test Plan

Screen Shot 2020-07-12 at 12.45.12 PM.png (146×1 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
publish14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24782
Build 34186: Run Core Tests
Build 34185: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 12 2020, 7:45 PM
Harbormaster completed remote builds in B24782: Diff 50962.Jul 12 2020, 7:47 PM
epriestley requested review of this revision.Jul 12 2020, 7:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2020, 4:04 PM
Closed by commit rP8aec3f916b39: Unify more build, property, auditor, and status information into… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP8aec3f916b39: Unify more build, property, auditor, and status information into….

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
audit/
query/
3 lines
diffusion/
view/
227 lines
view/
phui/
41 lines
webroot/
rsrc/
css/
phui/
object-item/
6 lines

Diff 50962

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
View Options

src/applications/diffusion/view/DiffusionCommitGraphView.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...
Phabricator · Built by Phacility