Page MenuHomePhabricator

Improve the quality of SSH error messages
ClosedPublic

Authored by epriestley on Jun 16 2020, 3:46 PM.
Tags
None
Referenced Files
F15438784: D21362.diff
Wed, Mar 26, 3:37 AM
F15399131: D21362.diff
Mon, Mar 17, 3:02 AM
F15379486: D21362.id50848.diff
Thu, Mar 13, 9:28 PM
Unknown Object (File)
Feb 27 2025, 7:47 AM
Unknown Object (File)
Feb 24 2025, 2:46 AM
Unknown Object (File)
Feb 21 2025, 10:24 PM
Unknown Object (File)
Feb 18 2025, 2:47 AM
Unknown Object (File)
Feb 9 2025, 7:37 PM
Subscribers
None

Details

Summary

See PHI1784. Currently, users who pass an invalid SSH command to Phabricator's SSH handler get an unhelpful error message. Make it more helpful.

Test Plan

Ran ./bin/ssh-exec with no arguments (old, helpful error), invalid arguments (before: unhelpful error; after: helpful error), and valid arguments (old, helpful behavior).

Diff Detail

Repository
rP Phabricator
Branch
ssh1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24667
Build 34013: Run Core Tests
Build 34012: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.