Page MenuHomePhabricator

Improve the quality of SSH error messages
ClosedPublic

Authored by epriestley on Jun 16 2020, 3:46 PM.
Tags
None
Referenced Files
F14496435: D21362.diff
Fri, Jan 3, 2:11 PM
Unknown Object (File)
Sat, Dec 21, 6:29 AM
Unknown Object (File)
Fri, Dec 6, 8:44 PM
Unknown Object (File)
Fri, Dec 6, 2:40 PM
Unknown Object (File)
Fri, Dec 6, 2:33 PM
Unknown Object (File)
Thu, Dec 5, 7:59 AM
Unknown Object (File)
Dec 3 2024, 3:53 PM
Unknown Object (File)
Nov 3 2024, 6:03 AM
Subscribers
None

Details

Summary

See PHI1784. Currently, users who pass an invalid SSH command to Phabricator's SSH handler get an unhelpful error message. Make it more helpful.

Test Plan

Ran ./bin/ssh-exec with no arguments (old, helpful error), invalid arguments (before: unhelpful error; after: helpful error), and valid arguments (old, helpful behavior).

Diff Detail

Repository
rP Phabricator
Branch
ssh1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24667
Build 34013: Run Core Tests
Build 34012: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.