Page MenuHomePhabricator

Improve the quality of SSH error messages
ClosedPublic

Authored by epriestley on Jun 16 2020, 3:46 PM.
Tags
None
Referenced Files
F21236831: D21362.id50849.diff
Tue, Jul 7, 9:22 PM
Unknown Object (File)
Sat, Jun 27, 1:15 PM
Unknown Object (File)
Mon, Jun 22, 7:43 PM
Unknown Object (File)
Sat, Jun 20, 11:35 PM
Unknown Object (File)
Mar 14 2026, 8:37 AM
Unknown Object (File)
Mar 13 2026, 10:05 PM
Unknown Object (File)
Feb 17 2026, 7:58 PM
Unknown Object (File)
Nov 22 2025, 1:52 PM
Subscribers
None

Details

Summary

See PHI1784. Currently, users who pass an invalid SSH command to Phabricator's SSH handler get an unhelpful error message. Make it more helpful.

Test Plan

Ran ./bin/ssh-exec with no arguments (old, helpful error), invalid arguments (before: unhelpful error; after: helpful error), and valid arguments (old, helpful behavior).

Diff Detail

Repository
rP Phabricator
Branch
ssh1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24667
Build 34013: Run Core Tests
Build 34012: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.