Page MenuHomePhabricator

Improve the quality of SSH error messages
ClosedPublic

Authored by epriestley on Jun 16 2020, 3:46 PM.
Tags
None
Referenced Files
F18797365: D21362.diff
Fri, Oct 17, 4:58 AM
F18763365: D21362.id50849.diff
Mon, Oct 6, 11:56 PM
F18635898: D21362.diff
Sep 17 2025, 2:58 AM
F18615097: D21362.id.diff
Sep 14 2025, 1:55 PM
F18609332: D21362.diff
Sep 14 2025, 2:59 AM
F18597074: D21362.diff
Sep 13 2025, 2:04 AM
F18517363: D21362.diff
Sep 5 2025, 1:25 PM
F18165738: D21362.id50848.diff
Aug 15 2025, 8:55 AM
Subscribers
None

Details

Summary

See PHI1784. Currently, users who pass an invalid SSH command to Phabricator's SSH handler get an unhelpful error message. Make it more helpful.

Test Plan

Ran ./bin/ssh-exec with no arguments (old, helpful error), invalid arguments (before: unhelpful error; after: helpful error), and valid arguments (old, helpful behavior).

Diff Detail

Repository
rP Phabricator
Branch
ssh1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24667
Build 34013: Run Core Tests
Build 34012: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.