Page MenuHomePhabricator

Update "arc land" display of build failures, and rename "DisplayRef" to "RefView"
ClosedPublic

Authored by epriestley on Jun 11 2020, 1:29 PM.
Tags
None
Referenced Files
F13131160: D21352.diff
Wed, May 1, 2:47 PM
Unknown Object (File)
Tue, Apr 30, 8:44 AM
Unknown Object (File)
Thu, Apr 25, 12:38 AM
Unknown Object (File)
Sat, Apr 20, 5:21 PM
Unknown Object (File)
Apr 1 2024, 8:06 PM
Unknown Object (File)
Mar 28 2024, 10:39 AM
Unknown Object (File)
Mar 5 2024, 3:16 PM
Unknown Object (File)
Feb 24 2024, 4:50 PM
Subscribers
None

Details

Summary

Ref T13546. Show ongoing and failed builds more clearly in "arc land" output.

Also rename "DisplayRef" (which is not a "Ref") to "RefView" with the goal of improving clarity, and let callers "build...()" it so they can add more status, etc., information.

Get rid of "[DisplayRef|RefView]Interface". In theory, future refs (say, in Phabricator) might not do anything here, but every Ref just ends up implementing it. This could perhaps be subclassed more narrowly in the future if necessary.

Test Plan

Ran "arc land", grepped for various symbols.

Diff Detail

Repository
rARC Arcanist
Branch
landx5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24649
Build 33983: Run Core Tests
Build 33982: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 30 2020, 1:28 PM
This revision was automatically updated to reflect the committed changes.