Page MenuHomePhabricator

In "arc land" in Mercurial, show a tidier "ls-remote" command
ClosedPublic

Authored by epriestley on Jun 10 2020, 3:30 PM.
Tags
None
Referenced Files
F15439349: D21344.id50808.diff
Wed, Mar 26, 7:06 AM
F15435175: D21344.id50812.diff
Tue, Mar 25, 7:15 AM
F15430742: D21344.id.diff
Mon, Mar 24, 8:44 AM
F15429218: D21344.id50812.diff
Mon, Mar 24, 1:11 AM
F15426408: D21344.diff
Sun, Mar 23, 8:32 AM
F15415189: D21344.id50812.diff
Thu, Mar 20, 4:43 AM
F15379473: D21344.id.diff
Thu, Mar 13, 9:24 PM
F15377951: D21344.diff
Thu, Mar 13, 11:36 AM
Subscribers
None

Details

Summary

Ref T9948. Ref T13546. We must passthru "hg ls-remote" because it might prompt the user for credentials.

Since "ls-remote" is implemented as an exension and we can't rely on using stdout beacuse of passthru, the actual command we execute is:

$ hg --config extensions.arc-hg=<huge long path to extension> arc-ls-remote --output <huge long path to temporary file> -- remote

This is meaningless and distracting; show the intent of the command we're executing instead. Users can see the raw command in "--trace" if they're actually debugging behavior.

Test Plan

Ran "arc land" in a Mercurial repository, got a tidier command output.

Diff Detail

Repository
rARC Arcanist
Branch
hg3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24629
Build 33953: Run Core Tests
Build 33952: arc lint + arc unit