Refine "arc land" behavior when pushing "onto" a new branch
ClosedPublic
Actions

Authored by epriestley on Jun 8 2020, 11:56 PM.

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC091aebe0149a: Refine "arc land" behavior when pushing "onto" a new branch

Summary

Ref T13546. If the "onto" branch doesn't exist yet and has a "/" in it, we need to preface it with "refs/heads" explicitly.

Fix a "false/null" issue with argument validation.

Possibly, "arc land" should prompt you before creating branches in the remote.

Test Plan

Ran "arc land --onto does-not-exist/1.1" and created a branch.

Diff Detail

Repository

rARC Arcanist

Branch

land35

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/land/engine/ArcanistGitLandEngine.php:889	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24625
Build 33946: Run Core Tests
Build 33945: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 8 2020, 11:56 PM

Harbormaster completed remote builds in B24625: Diff 50804.Jun 8 2020, 11:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:56 PM

epriestley requested review of this revision.

Closed by commit rARC091aebe0149a: Refine "arc land" behavior when pushing "onto" a new branch (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC091aebe0149a: Refine "arc land" behavior when pushing "onto" a new branch.

Revision Contents
Changeset List

Path

Size

src/

land/

engine/

ArcanistGitLandEngine.php

7 lines

ArcanistLandEngine.php

2 lines

Diff 50804

View Options

src/land/engine/ArcanistGitLandEngine.php