Page MenuHomePhabricator
Differential D21327

Show some "arc" help pages through a configurable pager, like "less"
ClosedPublic
Actions

Authored by epriestley on Jun 7 2020, 5:53 PM.
Tags
None
Referenced Files
F14767460: D21327.id50791.diff
Thu, Jan 23, 5:52 PM
Unknown Object (File)
Tue, Jan 21, 11:46 AM
Unknown Object (File)
Fri, Jan 17, 4:42 PM
Unknown Object (File)
Sun, Jan 12, 8:41 AM
Unknown Object (File)
Sat, Jan 11, 3:53 AM
Unknown Object (File)
Fri, Jan 10, 2:06 AM
Unknown Object (File)
Mon, Dec 30, 11:21 PM
Unknown Object (File)
Mon, Dec 30, 2:36 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T5420: Pipe output to a pager
Commits
rARCb62919f7e48a: Show some "arc" help pages through a configurable pager, like "less"
Summary

Fixes T5420. Some "arc help ..." is long and most similar commands send this kind of output through a pager.

Use a pager in at least some cases.

Test Plan

Ran "arc help land", got pager output. Ran "arc help land | cat", got raw output.

Diff Detail

Repository
rARC Arcanist
Branch
land20
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/parser/argument/workflow/PhutilHelpArgumentWorkflow.php:43XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24579
Build 33884: Run Core Tests
Build 33883: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 7 2020, 5:53 PM
Harbormaster completed remote builds in B24579: Diff 50757.Jun 7 2020, 5:53 PM
epriestley requested review of this revision.Jun 7 2020, 5:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:22 PM
Closed by commit rARCb62919f7e48a: Show some "arc" help pages through a configurable pager, like "less" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCb62919f7e48a: Show some "arc" help pages through a configurable pager, like "less".

Revision Contents
Changeset List

PathSize
src/
config/
arc/
12 lines
future/
exec/
21 lines
parser/
argument/
workflow/
29 lines
toolset/
workflow/
3 lines
workflow/
2 lines
26 lines

Diff 50757

View Options

src/config/arc/ArcanistArcConfigurationEngineExtension.php

Loading...
View Options

src/future/exec/PhutilExecPassthru.php

Loading...
View Options

src/parser/argument/workflow/PhutilHelpArgumentWorkflow.php

Loading...
View Options

src/toolset/workflow/ArcanistHelpWorkflow.php

Loading...
View Options

src/workflow/ArcanistLandWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility