In "arc branch" output, sort branches updated in the same second by name
ClosedPublic
Actions

Authored by epriestley on Jun 5 2020, 10:30 PM.

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC7d615a97e240: In "arc branch" output, sort branches updated in the same second by name

Summary

Ref T13546. The new "arc land" workflow can rebase several branches per second. With branches like "feature1", "feature2", etc., this leads to out-of-order listing in "arc branch".

When two branches would otherwise sort to the same position, sort them by name.

Test Plan

Ran "arc branch" after a cascading rebase by "arc land", saw "land5", "land7", "land8", etc., instead of an arbitrary order.

Diff Detail

Repository

rARC Arcanist

Branch

land13

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24566
Build 33861: Run Core Tests
Build 33860: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 5 2020, 10:30 PM

Harbormaster completed remote builds in B24566: Diff 50744.Jun 5 2020, 10:31 PM

epriestley requested review of this revision.Jun 5 2020, 10:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 11:04 PM

Closed by commit rARC7d615a97e240: In "arc branch" output, sort branches updated in the same second by name (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC7d615a97e240: In "arc branch" output, sort branches updated in the same second by name.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistFeatureBaseWorkflow.php

31 lines

Diff 50744

View Options

src/workflow/ArcanistFeatureBaseWorkflow.php

In "arc branch" output, sort branches updated in the same second by nameClosedPublicActions