Page MenuHomePhabricator

Impose a HardpointEngine future parallelism limit
ClosedPublic

Authored by epriestley on Jun 4 2020, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 1:26 AM
Unknown Object (File)
Fri, Apr 26, 12:00 PM
Unknown Object (File)
Thu, Apr 25, 12:57 AM
Unknown Object (File)
Sat, Apr 20, 5:16 PM
Unknown Object (File)
Thu, Apr 18, 4:42 AM
Unknown Object (File)
Tue, Apr 16, 4:18 PM
Unknown Object (File)
Fri, Apr 5, 4:27 PM
Unknown Object (File)
Feb 22 2024, 10:37 PM
Subscribers
None

Details

Summary

Ref T13546. If we try to resolve several hundred hardpoint queries which execute subprocesses, we can currently hit system limits.

For now, limit resolution to 32 simultaneous futures. In the future, this should switch to FuturePool and possibly become more nuanced.

Test Plan

In a future change, ran arc land --into-empty ... to land thousands of commits. Before change, got a "proc_open()" error when launching too many simultaneous subprocesses. After change, this "worked".

Diff Detail

Repository
rARC Arcanist
Branch
land1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24547
Build 33833: Run Core Tests
Build 33832: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2020, 7:15 PM
This revision was automatically updated to reflect the committed changes.