Page MenuHomePhabricator

Remove "--apply-patches" and "--never-apply-patches" from "arc diff"
Needs ReviewPublic

Authored by epriestley on May 30 2020, 10:47 PM.
Tags
None
Referenced Files
F13288171: D21302.diff
Tue, Jun 4, 9:54 AM
F13280539: D21302.id50719.diff
Sun, Jun 2, 6:36 AM
F13276151: D21302.diff
Fri, May 31, 5:36 AM
F13271065: D21302.diff
Wed, May 29, 4:06 PM
F13240238: D21302.id50719.diff
Wed, May 22, 12:05 PM
F13239893: D21302.id.diff
Wed, May 22, 7:46 AM
F13222216: D21302.diff
Sun, May 19, 3:25 AM
F13204756: D21302.diff
Wed, May 15, 12:54 AM
Subscribers
None
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T13544: Modernize the "arc diff" workflow
Summary

Ref T13544. These are passthrough flags that control the behavior of the "arc lint" subprocess.

I suspect all use cases of "--apply-patches" are better served by a prompt default via "arc prompts".

I suspect all use cases of "--never-apply-patches" are better served by either using prompt defaults or by using "--nolint", which accomplishes the same goal ("ignore lint") much faster. If you want to look at lint and make a nuanced decision about what to act on, you can use "arc lint".

Test Plan

Searched for "apply-patches" and "never-apply-patches", created this revision.

Diff Detail

Repository
rARC Arcanist
Branch
xdiff7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24541
Build 33823: Run Core Tests
Build 33822: arc lint + arc unit