Page MenuHomePhabricator

Remove "--apply-patches" and "--never-apply-patches" from "arc diff"
Needs ReviewPublic

Authored by epriestley on May 30 2020, 10:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 12:43 PM
Unknown Object (File)
Sun, Mar 3, 2:00 PM
Unknown Object (File)
Feb 15 2024, 8:31 AM
Unknown Object (File)
Feb 14 2024, 2:47 AM
Unknown Object (File)
Feb 10 2024, 7:02 PM
Unknown Object (File)
Feb 2 2024, 9:24 AM
Unknown Object (File)
Jan 9 2024, 8:09 AM
Unknown Object (File)
Dec 31 2023, 3:06 AM
Subscribers
None
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T13544: Modernize the "arc diff" workflow
Summary

Ref T13544. These are passthrough flags that control the behavior of the "arc lint" subprocess.

I suspect all use cases of "--apply-patches" are better served by a prompt default via "arc prompts".

I suspect all use cases of "--never-apply-patches" are better served by either using prompt defaults or by using "--nolint", which accomplishes the same goal ("ignore lint") much faster. If you want to look at lint and make a nuanced decision about what to act on, you can use "arc lint".

Test Plan

Searched for "apply-patches" and "never-apply-patches", created this revision.

Diff Detail

Repository
rARC Arcanist
Branch
xdiff7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24541
Build 33823: Run Core Tests
Build 33822: arc lint + arc unit