Page MenuHomePhabricator

Make lint tests handle paths better and distinguish between "0" and "null" more carefully
ClosedPublic

Authored by epriestley on May 27 2020, 7:36 PM.
Tags
None
Referenced Files
F15360783: D21291.id50702.diff
Tue, Mar 11, 10:14 AM
F15329765: D21291.diff
Fri, Mar 7, 7:01 AM
Unknown Object (File)
Feb 12 2025, 9:40 PM
Unknown Object (File)
Feb 9 2025, 9:24 AM
Unknown Object (File)
Feb 9 2025, 9:24 AM
Unknown Object (File)
Feb 9 2025, 9:24 AM
Unknown Object (File)
Jan 30 2025, 6:53 PM
Unknown Object (File)
Jan 28 2025, 8:35 PM
Subscribers
None

Details

Summary

Ref T13543. Currently, the cpplint tests do not function because cpplint is passed a path which does not end in a suffix it recognizes.

Change the tempfile / path code to pass linter path/to/example.c-style linters a path they expect.

Then, correct some older code which was playing it fast-and-loose with "null" vs "0".

Test Plan

Ran arc unit --everything, got a clean bill of health on all the linters I have installed. (This is probably not all tests, since I have only a subset of linters installed locally that we have code for.)

Diff Detail

Repository
rARC Arcanist
Branch
lunit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24522
Build 33793: Run Core Tests
Build 33792: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 27 2020, 7:37 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.