Page MenuHomePhabricator

Make lint tests handle paths better and distinguish between "0" and "null" more carefully
ClosedPublic

Authored by epriestley on May 27 2020, 7:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 7:25 AM
Unknown Object (File)
Jan 31 2024, 3:50 PM
Unknown Object (File)
Jan 20 2024, 5:46 PM
Unknown Object (File)
Jan 20 2024, 2:14 PM
Unknown Object (File)
Jan 17 2024, 10:09 AM
Unknown Object (File)
Dec 14 2023, 2:19 AM
Unknown Object (File)
Dec 5 2023, 2:46 PM
Unknown Object (File)
Nov 30 2023, 2:06 AM
Subscribers
None

Details

Summary

Ref T13543. Currently, the cpplint tests do not function because cpplint is passed a path which does not end in a suffix it recognizes.

Change the tempfile / path code to pass linter path/to/example.c-style linters a path they expect.

Then, correct some older code which was playing it fast-and-loose with "null" vs "0".

Test Plan

Ran arc unit --everything, got a clean bill of health on all the linters I have installed. (This is probably not all tests, since I have only a subset of linters installed locally that we have code for.)

Diff Detail

Repository
rARC Arcanist
Branch
lunit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24522
Build 33793: Run Core Tests
Build 33792: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 27 2020, 7:37 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.