Page MenuHomePhabricator

In the "cpplint" binding, raise messages on "line 0" without a line
ClosedPublic

Authored by epriestley on May 27 2020, 5:58 PM.
Tags
None
Referenced Files
F15414445: D21289.diff
Thu, Mar 20, 12:37 AM
F15412888: D21289.diff
Wed, Mar 19, 3:34 PM
F15402361: D21289.id50696.diff
Mon, Mar 17, 10:09 PM
F15386956: D21289.id.diff
Sat, Mar 15, 1:34 AM
F15377238: D21289.id50697.diff
Thu, Mar 13, 8:26 AM
F15333303: D21289.diff
Sat, Mar 8, 1:40 AM
Unknown Object (File)
Thu, Feb 27, 3:35 AM
Unknown Object (File)
Wed, Feb 26, 8:04 AM
Subscribers
None

Details

Summary

Ref T13543. The "cpplint.py" script may emit messages on line 0, but Arcanist doesn't accept these messages.

This is a small piece of a whole set of broader issues, but stop the bleeding for now.

Test Plan
  • Ran arc lint example.h on a file with no #ifndef guard, and cpplint configured.
  • Cpplint raised a message at line "0".
  • Before change: arc choked when trying to render this.
  • After change: arc survives rendering.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable