Page MenuHomePhabricator

In the "cpplint" binding, raise messages on "line 0" without a line
ClosedPublic

Authored by epriestley on May 27 2020, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 1:18 PM
Unknown Object (File)
Feb 7 2024, 5:48 AM
Unknown Object (File)
Dec 27 2023, 8:54 PM
Unknown Object (File)
Dec 20 2023, 7:43 AM
Unknown Object (File)
Dec 17 2023, 6:26 PM
Unknown Object (File)
Nov 30 2023, 2:08 AM
Unknown Object (File)
Nov 25 2023, 11:36 PM
Unknown Object (File)
Nov 15 2023, 9:53 PM
Subscribers
None

Details

Summary

Ref T13543. The "cpplint.py" script may emit messages on line 0, but Arcanist doesn't accept these messages.

This is a small piece of a whole set of broader issues, but stop the bleeding for now.

Test Plan
  • Ran arc lint example.h on a file with no #ifndef guard, and cpplint configured.
  • Cpplint raised a message at line "0".
  • Before change: arc choked when trying to render this.
  • After change: arc survives rendering.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable