In the "cpplint" binding, raise messages on "line 0" without a line
ClosedPublic
Actions

Authored by epriestley on May 27 2020, 5:58 PM.

Details

Reviewers: None
Maniphest Tasks: T13543: Older linters may raise unusual messages which cause errors under stricter runtime validation
Commits: rARC609c8c9fdc32: (stable) In the "cpplint" binding, raise messages on "line 0" without a line
rARC25ee39b657b8: In the "cpplint" binding, raise messages on "line 0" without a line

Summary

Ref T13543. The "cpplint.py" script may emit messages on line 0, but Arcanist doesn't accept these messages.

This is a small piece of a whole set of broader issues, but stop the bleeding for now.

Test Plan

Ran arc lint example.h on a file with no #ifndef guard, and cpplint configured.
Cpplint raised a message at line "0".
Before change: arc choked when trying to render this.
After change: arc survives rendering.

Repository

rARC Arcanist

Branch

cpplint1

Lint

Lint Passed

Unit

Test Failures

Build Status

	Time	Test
	96 ms	ArcanistCpplintLinterTestCase::testLinter EXCEPTION (Exception): Parameter passed to "setChar()" must be an integer. #0 /Users/epriestley/dev/core/lib/arcanist/src/lint/ArcanistLintMessage.php(92): ArcanistLintMessage->validateInteger('', 'setChar') #1 /Users/epriestley/dev/core/lib/arcanist/src/lint/linter/__tests__/ArcanistLinterTestCase.php(203): ArcanistLintMessage->setChar('')
	0 ms	AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNoncyclicGraph 1 assertion(s) passed.
		View Full Test Results (1 Failed · 490 Passed · 62 Skipped)