Page MenuHomePhabricator

When cancelling an edit of an inline with content, don't hide the inline
ClosedPublic

Authored by epriestley on May 22 2020, 10:29 PM.
Tags
None
Referenced Files
F15420932: D21286.id.diff
Fri, Mar 21, 7:13 PM
F15420197: D21286.diff
Fri, Mar 21, 12:09 PM
F15389496: D21286.id.diff
Sat, Mar 15, 5:20 AM
F15318209: D21286.diff
Thu, Mar 6, 8:15 PM
Unknown Object (File)
Mon, Mar 3, 5:30 PM
Unknown Object (File)
Sat, Feb 22, 8:04 AM
Unknown Object (File)
Feb 9 2025, 9:23 AM
Unknown Object (File)
Feb 9 2025, 9:23 AM
Subscribers
None

Details

Summary

See PHI1753. This condition got rewritten for suggested edits and accidentally inverted.

Test Plan
  • Create a comment, type text, save draft, edit comment, cancel.
  • Before: comment hides itself.
  • After: comment properly cancels into pre-edit draft state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable