Page MenuHomePhabricator

Use the changeset parse cache to cache suggestion changesets
ClosedPublic

Authored by epriestley on May 20 2020, 6:37 PM.
Tags
None
Referenced Files
F13198448: D21280.id50674.diff
Mon, May 13, 6:38 AM
F13197470: D21280.diff
Mon, May 13, 12:12 AM
F13179943: D21280.diff
Wed, May 8, 9:33 PM
Unknown Object (File)
Mon, May 6, 12:52 PM
Unknown Object (File)
Mon, May 6, 8:30 AM
Unknown Object (File)
Mon, May 6, 5:31 AM
Unknown Object (File)
Sun, May 5, 8:55 PM
Unknown Object (File)
Sat, May 4, 7:22 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13513. Syntax highlighting is potentially expensive, and the changeset rendering pipeline can cache it. However, the cache is currently keyed ONLY by Differential changeset ID.

Destroy the existing cache and rebuild it with a more standard cache key so it can be used in a more ad-hoc way by inline suggestion snippets.

Test Plan

Used Darkconsole, saw cache hits and no more inline syntax highlighting for changesets with many inlines.

Diff Detail

Repository
rP Phabricator
Branch
inline14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24484
Build 33742: Run Core Tests
Build 33741: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 20 2020, 6:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:29 PM
This revision was automatically updated to reflect the committed changes.