Page MenuHomePhabricator

Use the changeset parse cache to cache suggestion changesets
ClosedPublic

Authored by epriestley on May 20 2020, 6:37 PM.
Tags
None
Referenced Files
F12831961: D21280.id.diff
Thu, Mar 28, 1:06 PM
Unknown Object (File)
Sun, Mar 24, 8:31 PM
Unknown Object (File)
Jan 16 2024, 6:18 AM
Unknown Object (File)
Jan 13 2024, 2:28 AM
Unknown Object (File)
Jan 9 2024, 8:10 AM
Unknown Object (File)
Jan 6 2024, 8:36 PM
Unknown Object (File)
Dec 26 2023, 8:57 PM
Unknown Object (File)
Dec 26 2023, 5:10 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13513. Syntax highlighting is potentially expensive, and the changeset rendering pipeline can cache it. However, the cache is currently keyed ONLY by Differential changeset ID.

Destroy the existing cache and rebuild it with a more standard cache key so it can be used in a more ad-hoc way by inline suggestion snippets.

Test Plan

Used Darkconsole, saw cache hits and no more inline syntax highlighting for changesets with many inlines.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 20 2020, 6:37 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:29 PM
This revision was automatically updated to reflect the committed changes.