Page MenuHomePhabricator
Differential D21277

Render inline comment suggestions as real diffs
ClosedPublic
Actions

Authored by epriestley on May 20 2020, 4:10 PM.
Tags
None
Referenced Files
F15400476: D21277.id50662.diff
Mon, Mar 17, 11:52 AM
F15382624: D21277.diff
Fri, Mar 14, 1:26 PM
F15316234: D21277.diff
Thu, Mar 6, 6:27 PM
Unknown Object (File)
Mon, Feb 24, 2:45 AM
Unknown Object (File)
Sat, Feb 22, 4:46 PM
Unknown Object (File)
Fri, Feb 21, 3:54 AM
Unknown Object (File)
Wed, Feb 19, 2:40 AM
Unknown Object (File)
Tue, Feb 18, 4:49 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP10f241352dce: Render inline comment suggestions as real diffs
Summary

Ref T13513. When rendering an inline suggestion for display, use highlighting and diffing.

Test Plan

Screen Shot 2020-05-20 at 9.02.43 AM.png (232×957 px, 34 KB)

Diff Detail

Repository
rP Phabricator
Branch
inline11
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php:550XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24481
Build 33736: Run Core Tests
Build 33735: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2020, 4:10 PM
Harbormaster completed remote builds in B24481: Diff 50662.May 20 2020, 4:12 PM
epriestley requested review of this revision.May 20 2020, 4:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:27 PM
Closed by commit rP10f241352dce: Render inline comment suggestions as real diffs (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP10f241352dce: Render inline comment suggestions as real diffs.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
parser/
5 lines
render/
39 lines
infrastructure/
diff/
inline/
10 lines
query/
5 lines
view/
27 lines
webroot/
rsrc/
css/
application/
differential/
24 lines

Diff 50662

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
View Options

src/infrastructure/diff/inline/PhabricatorDiffInlineCommentContext.php

Loading...
View Options

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

Loading...
Phabricator · Built by Phacility