Page MenuHomePhabricator

Render inline comment suggestions as real diffs
ClosedPublic

Authored by epriestley on May 20 2020, 4:10 PM.

Details

Summary

Ref T13513. When rendering an inline suggestion for display, use highlighting and diffing.

Test Plan

Screen Shot 2020-05-20 at 9.02.43 AM.png (232×957 px, 34 KB)

Diff Detail

Repository
rP Phabricator
Branch
inline11
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php:550XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24481
Build 33736: Run Core Tests
Build 33735: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:27 PM
This revision was automatically updated to reflect the committed changes.