Fix "r" and "R" both replying with quote on inline comments
ClosedPublic
Actions

Authored by epriestley on May 19 2020, 4:26 PM.

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rP8dec499bcf0a: (stable) Fix "r" and "R" both replying with quote on inline comments
rP770a5c8412d1: Fix "r" and "R" both replying with quote on inline comments

Summary

Ref T13513. The code which added "r" and "R" to the inline menu accidentally discarded the difference between the keystrokes.

Test Plan

Clicked an inline, pressed "r", got new empty inline (previously: inline with quote).
Clicked an inline, pressed "R", got a new quoted inline.
Repeated steps with the menu items, got the expected behaviors.

Diff Detail

Repository

rP Phabricator

Branch

replykey1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24463
Build 33709: Run Core Tests
Build 33708: arc lint + arc unit

Event Timeline

epriestley created this revision.May 19 2020, 4:26 PM

Harbormaster completed remote builds in B24463: Diff 50644.May 19 2020, 4:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2020, 4:28 PM

epriestley requested review of this revision.

Closed by commit rP770a5c8412d1: Fix "r" and "R" both replying with quote on inline comments (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP770a5c8412d1: Fix "r" and "R" both replying with quote on inline comments.

epriestley added a commit: rP8dec499bcf0a: (stable) Fix "r" and "R" both replying with quote on inline comments.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

2 lines

Diff 50644

View Options

resources/celerity/map.php