Page MenuHomePhabricator

Fix "r" and "R" both replying with quote on inline comments
ClosedPublic

Authored by epriestley on May 19 2020, 4:26 PM.
Tags
None
Referenced Files
F12851394: D21268.id.diff
Fri, Mar 29, 6:30 AM
Unknown Object (File)
Sun, Mar 24, 8:28 PM
Unknown Object (File)
Sun, Mar 10, 9:12 PM
Unknown Object (File)
Feb 12 2024, 10:35 AM
Unknown Object (File)
Dec 26 2023, 3:16 AM
Unknown Object (File)
Nov 30 2023, 12:57 AM
Unknown Object (File)
Nov 25 2023, 11:33 PM
Unknown Object (File)
Nov 15 2023, 11:03 AM
Subscribers
None

Details

Summary

Ref T13513. The code which added "r" and "R" to the inline menu accidentally discarded the difference between the keystrokes.

Test Plan
  • Clicked an inline, pressed "r", got new empty inline (previously: inline with quote).
  • Clicked an inline, pressed "R", got a new quoted inline.
  • Repeated steps with the menu items, got the expected behaviors.

Diff Detail

Repository
rP Phabricator
Branch
replykey1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24463
Build 33709: Run Core Tests
Build 33708: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2020, 4:28 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.