Paths

Table of Contentst

Differential D21251

Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()"
ClosedPublic
Actions

Authored by epriestley on May 14 2020, 4:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 7:41 AM

	Unknown Object (File)
	Thu, Apr 25, 1:40 AM

	Unknown Object (File)
	Thu, Apr 11, 9:29 AM

	Unknown Object (File)
	Sat, Apr 6, 4:42 PM

	Unknown Object (File)
	Mar 29 2024, 11:37 AM

	Unknown Object (File)
	Mar 29 2024, 2:02 AM

	Unknown Object (File)
	Mar 28 2024, 1:15 AM

	Unknown Object (File)
	Mar 10 2024, 12:57 PM

View All 57 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13533: Support arbitrary cURL options, for Kerberos auth
Commits: rARCb76b9c4065bb: Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()"

Summary

Fixes T13533. This is a narrow, fragile API for a particular Kerberos use case on one install.

Test Plan

Set a non-scalar key, got an exception.
Set <"duck", "quack">, got an exception from cURL that the value was invalid.
Set a bunch of made-up options to arbitrary values, no errors. cURL accepts anything so there's nothing we can do about this.
Set CURLOPT_NOBODY and saw the request behavior change, demonstrating that the call can produce effects.

Diff Detail

Repository

Branch

curl1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24423
Build 33652: Run Core Tests
Build 33651: arc lint + arc unit

Event Timeline

epriestley created this revision.May 14 2020, 4:14 PM

Harbormaster completed remote builds in B24423: Diff 50606.May 14 2020, 4:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 4:15 PM

epriestley requested review of this revision.

Closed by commit rARCb76b9c4065bb: Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCb76b9c4065bb: Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()".

Revision Contents
Changeset List

Path

Size

src/

future/

http/

HTTPSFuture.php

36 lines

Diff 50606

src/future/http/HTTPSFuture.php

Loading...