Page MenuHomePhabricator

Add "HTTPSFuture->addCurlOption()" for raw access to "curl_setopt()"
ClosedPublic

Authored by epriestley on May 14 2020, 4:14 PM.
Tags
None
Referenced Files
F12847305: D21251.diff
Fri, Mar 29, 2:02 AM
Unknown Object (File)
Thu, Mar 28, 1:15 AM
Unknown Object (File)
Sun, Mar 10, 12:57 PM
Unknown Object (File)
Feb 14 2024, 3:32 PM
Unknown Object (File)
Dec 27 2023, 1:24 PM
Unknown Object (File)
Dec 25 2023, 1:36 PM
Unknown Object (File)
Dec 22 2023, 2:59 AM
Unknown Object (File)
Dec 15 2023, 3:06 PM
Subscribers
None

Details

Summary

Fixes T13533. This is a narrow, fragile API for a particular Kerberos use case on one install.

Test Plan
  • Set a non-scalar key, got an exception.
  • Set <"duck", "quack">, got an exception from cURL that the value was invalid.
  • Set a bunch of made-up options to arbitrary values, no errors. cURL accepts anything so there's nothing we can do about this.
  • Set CURLOPT_NOBODY and saw the request behavior change, demonstrating that the call can produce effects.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 4:15 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.