Page MenuHomePhabricator
Differential D21246

Add "View Raw Remarkup" to inline comments
ClosedPublic
Actions

Authored by epriestley on May 13 2020, 4:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 9:47 PM
Unknown Object (File)
Thu, Nov 21, 6:02 PM
Unknown Object (File)
Oct 23 2024, 2:38 AM
Unknown Object (File)
Oct 9 2024, 1:24 PM
Unknown Object (File)
Oct 9 2024, 1:24 PM
Unknown Object (File)
Oct 9 2024, 1:24 PM
Unknown Object (File)
Oct 7 2024, 10:02 PM
Unknown Object (File)
Sep 30 2024, 6:37 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11401: Add ability to quote, edit, view raw, view history, and remove inline comments
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rPc063e0e5ec9d: Add "View Raw Remarkup" to inline comments
Summary

Ref T13513. Ref T11401. Support viewing raw remarkup for inlines.

Test Plan

Viewed raw remarkup on inlines.

Diff Detail

Repository
rP Phabricator
Branch
engine6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24412
Build 33636: Run Core Tests
Build 33635: arc lint + arc unit

Event Timeline

epriestley created this revision.May 13 2020, 4:31 PM
Harbormaster completed remote builds in B24412: Diff 50595.May 13 2020, 4:32 PM
epriestley requested review of this revision.May 13 2020, 4:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:14 AM
Closed by commit rPc063e0e5ec9d: Add "View Raw Remarkup" to inline comments (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPc063e0e5ec9d: Add "View Raw Remarkup" to inline comments.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
transactions/
storage/
5 lines
infrastructure/
diff/
view/
28 lines
view/
phui/
2 lines
webroot/
rsrc/
js/
application/
diff/
8 lines

Diff 50595

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransactionComment.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility