Page MenuHomePhabricator
Differential D21244

Move inline comment actions into a dropdown menu
ClosedPublic
Actions

Authored by epriestley on May 13 2020, 12:57 PM.
Tags
None
Referenced Files
F13157962: D21244.id50601.diff
Sun, May 5, 3:42 PM
Unknown Object (File)
Fri, May 3, 8:27 AM
Unknown Object (File)
Sun, Apr 28, 2:38 AM
Unknown Object (File)
Sat, Apr 27, 6:00 PM
Unknown Object (File)
Fri, Apr 26, 2:07 PM
Unknown Object (File)
Thu, Apr 25, 2:19 AM
Unknown Object (File)
Tue, Apr 23, 2:38 AM
Unknown Object (File)
Sat, Apr 6, 7:48 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11401: Add ability to quote, edit, view raw, view history, and remove inline comments
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP419b7ceebb0f: Move inline comment actions into a dropdown menu
Summary

Ref T11401. Ref T13513. This paves the way for more comment actions, particularly an edit-after-submit action.

Test Plan

Took all actions from menus, via mouse and via keyboard (where applicable).

Diff Detail

Repository
rP Phabricator
Branch
engine5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24409
Build 33631: Run Core Tests
Build 33630: arc lint + arc unit

Event Timeline

epriestley created this revision.May 13 2020, 12:57 PM
Harbormaster completed remote builds in B24409: Diff 50592.May 13 2020, 12:58 PM
epriestley requested review of this revision.May 13 2020, 12:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 14 2020, 12:13 AM
Closed by commit rP419b7ceebb0f: Move inline comment actions into a dropdown menu (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP419b7ceebb0f: Move inline comment actions into a dropdown menu.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
infrastructure/
diff/
view/
127 lines
webroot/
rsrc/
js/
application/
diff/
38 lines
137 lines

Diff 50592

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility