Page MenuHomePhabricator
Differential D21243

Render proper "Show Context" links in DocumentEngine diffs, not just bullets
ClosedPublic
Actions

Authored by epriestley on May 12 2020, 11:00 PM.
Tags
None
Referenced Files
F15461558: D21243.id50590.diff
Tue, Apr 1, 9:14 AM
F15455120: D21243.id.diff
Sat, Mar 29, 10:20 PM
F15449154: D21243.diff
Fri, Mar 28, 8:36 AM
F15316145: D21243.diff
Thu, Mar 6, 6:23 PM
Unknown Object (File)
Feb 24 2025, 2:43 AM
Unknown Object (File)
Feb 24 2025, 1:55 AM
Unknown Object (File)
Feb 17 2025, 1:41 AM
Unknown Object (File)
Feb 9 2025, 9:16 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rPdf139f044b9b: Render proper "Show Context" links in DocumentEngine diffs, not just bullets
Summary

Ref T13513. Currently, viewing a Jupyter document, hidden context just gets a plain "* * *" facade with no way to expand it.

Support click-to-expand, like source changes.

Test Plan
  • Clicked to expand various Jupyter diffs.
  • Clicked to expand normal source changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 12 2020, 11:00 PM
Harbormaster completed remote builds in B24407: Diff 50590.May 12 2020, 11:01 PM
epriestley requested review of this revision.May 12 2020, 11:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 12 2020, 11:09 PM
Closed by commit rPdf139f044b9b: Render proper "Show Context" links in DocumentEngine diffs, not just bullets (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPdf139f044b9b: Render proper "Show Context" links in DocumentEngine diffs, not just bullets.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
parser/
16 lines
render/
41 lines
56 lines
files/
diff/
76 lines
infrastructure/
internationalization/
translation/
45 lines

Diff 50591

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
View Options

src/applications/files/diff/PhabricatorDocumentEngineBlocks.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility