Page MenuHomePhabricator

Render proper "Show Context" links in DocumentEngine diffs, not just bullets
ClosedPublic

Authored by epriestley on May 12 2020, 11:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 10:22 AM
Unknown Object (File)
Mon, Nov 18, 8:21 PM
Unknown Object (File)
Sat, Nov 9, 4:09 PM
Unknown Object (File)
Mon, Nov 4, 6:12 PM
Unknown Object (File)
Oct 23 2024, 7:17 AM
Unknown Object (File)
Oct 20 2024, 11:33 PM
Unknown Object (File)
Oct 20 2024, 9:52 PM
Unknown Object (File)
Oct 20 2024, 6:04 PM
Subscribers
None

Details

Summary

Ref T13513. Currently, viewing a Jupyter document, hidden context just gets a plain "* * *" facade with no way to expand it.

Support click-to-expand, like source changes.

Test Plan
  • Clicked to expand various Jupyter diffs.
  • Clicked to expand normal source changes.

Diff Detail

Repository
rP Phabricator
Branch
engine4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24407
Build 33628: Run Core Tests
Build 33627: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 12 2020, 11:09 PM
This revision was automatically updated to reflect the committed changes.