Page MenuHomePhabricator

Fix an issue where storage inlines are fed to InlineAdjustmentEngine
ClosedPublic

Authored by epriestley on May 8 2020, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 8:45 AM
Unknown Object (File)
Sat, Feb 22, 6:27 AM
Unknown Object (File)
Feb 9 2025, 9:16 AM
Unknown Object (File)
Feb 9 2025, 9:15 AM
Unknown Object (File)
Feb 9 2025, 9:15 AM
Unknown Object (File)
Feb 9 2025, 9:15 AM
Unknown Object (File)
Jan 25 2025, 7:37 AM
Unknown Object (File)
Jan 25 2025, 7:37 AM
Subscribers
None

Details

Summary

Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing.

Add the conversion step.

Test Plan

Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal.

Diff Detail

Repository
rP Phabricator
Branch
inline1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24397
Build 33613: Run Core Tests
Build 33612: arc lint + arc unit