Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing.
Add the conversion step.
Differential D21239
Fix an issue where storage inlines are fed to InlineAdjustmentEngine epriestley on May 8 2020, 11:51 PM. Authored by Tags None Referenced Files
Subscribers None
Details Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing. Add the conversion step. Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal.
Diff Detail
|