Make "Delete" from inline comment previews function correctly while editing comments
ClosedPublic
Actions

Authored by epriestley on May 8 2020, 3:09 PM.

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rPe7ebd5d9d1f8: Make "Delete" from inline comment previews function correctly while editing…

Summary

Ref T13513. Currently, if you're editing a comment, "delete" doesn't put the comment into the correct state. This action is normally only reachable from comment previews, since an editing inline has no "delete" button.

Test Plan

Started editing an inline, clicked "Delete", got a deletion.
Created an inline, typed text,
Deleted a normal comment via preview.
Deleted a normal comment via the on-inline action.

Diff Detail

Repository

rP Phabricator

Branch

inline4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24392
Build 33607: Run Core Tests
Build 33606: arc lint + arc unit

Event Timeline

epriestley created this revision.May 8 2020, 3:09 PM

Harbormaster completed remote builds in B24392: Diff 50576.May 8 2020, 3:11 PM

epriestley requested review of this revision.May 8 2020, 3:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 8 2020, 3:54 PM

Closed by commit rPe7ebd5d9d1f8: Make "Delete" from inline comment previews function correctly while editing… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPe7ebd5d9d1f8: Make "Delete" from inline comment previews function correctly while editing….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

32 lines

Diff 50576

View Options

resources/celerity/map.php