Page MenuHomePhabricator

Make InlineCommentQueries more robust/consistent
ClosedPublic

Authored by epriestley on May 7 2020, 5:56 PM.
Tags
None
Referenced Files
F15457822: D21227.id50563.diff
Sun, Mar 30, 7:11 PM
F15452535: D21227.id.diff
Sat, Mar 29, 5:50 AM
F15451806: D21227.diff
Fri, Mar 28, 11:55 PM
F15424938: D21227.diff
Sun, Mar 23, 1:16 AM
F15377240: D21227.id50552.diff
Thu, Mar 13, 8:26 AM
F15333411: D21227.diff
Sat, Mar 8, 2:13 AM
Unknown Object (File)
Mon, Mar 3, 9:31 PM
Unknown Object (File)
Feb 21 2025, 2:16 AM
Subscribers
None

Details

Summary

Ref T13513. Improve consistency and robustness of the "InlineComment" queries.

The only real change here is that these queries now implicitly add a clause for selecting inlines ("pathID IS NULL" or "changesetID IS NULL").

Test Plan

Browed, created, edited, and submitted inlines.

Diff Detail

Repository
rP Phabricator
Branch
iquery4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24368
Build 33571: Run Core Tests
Build 33570: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:00 PM
This revision was automatically updated to reflect the committed changes.