Page MenuHomePhabricator

Make InlineCommentQueries more robust/consistent
ClosedPublic

Authored by epriestley on May 7 2020, 5:56 PM.
Tags
None
Referenced Files
F13088587: D21227.diff
Thu, Apr 25, 1:29 AM
Unknown Object (File)
Thu, Apr 11, 8:59 AM
Unknown Object (File)
Tue, Apr 2, 6:53 PM
Unknown Object (File)
Mar 5 2024, 9:04 PM
Unknown Object (File)
Jan 17 2024, 12:35 AM
Unknown Object (File)
Dec 21 2023, 4:10 PM
Unknown Object (File)
Dec 21 2023, 3:07 PM
Unknown Object (File)
Dec 16 2023, 9:30 AM
Subscribers
None

Details

Summary

Ref T13513. Improve consistency and robustness of the "InlineComment" queries.

The only real change here is that these queries now implicitly add a clause for selecting inlines ("pathID IS NULL" or "changesetID IS NULL").

Test Plan

Browed, created, edited, and submitted inlines.

Diff Detail

Repository
rP Phabricator
Branch
iquery4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24368
Build 33571: Run Core Tests
Build 33570: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:00 PM
This revision was automatically updated to reflect the committed changes.