" to the upstream editor whitelist
ClosedPublic
Actions

Authored by epriestley on May 1 2020, 7:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Feb 1, 8:03 AM

	Unknown Object (File)
	Mon, Jan 27, 5:16 PM

	Unknown Object (File)
	Sat, Jan 25, 12:11 AM

	Unknown Object (File)
	Sun, Jan 12, 10:40 AM

	Unknown Object (File)
	Jan 2 2025, 12:11 AM

	Unknown Object (File)
	Dec 14 2024, 3:37 AM

	Unknown Object (File)
	Oct 17 2024, 12:56 AM

	Unknown Object (File)
	Sep 24 2024, 12:29 AM

View All 87 Files

Subscribers

None

Details

Reviewers: None
Commits: rPb89e6c0fa91a: Add "idea://" to the upstream editor whitelist

Summary

This supports the IntelliJ IDEA editor.

Test Plan

Looked at the editor settings panel, saw "idea://".
Set my editor pattern to "idea://a?b".
(Did not actually install IntelliJ IDEA.)

Diff Detail

Repository

rP Phabricator

Branch

idea1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24315
Build 33497: Run Core Tests
Build 33496: arc lint + arc unit

Event Timeline

epriestley created this revision.May 1 2020, 7:53 PM

Harbormaster completed remote builds in B24315: Diff 50500.May 1 2020, 7:54 PM

epriestley requested review of this revision.May 1 2020, 7:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 7:56 PM

Closed by commit rPb89e6c0fa91a: Add "idea://" to the upstream editor whitelist (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb89e6c0fa91a: Add "idea://" to the upstream editor whitelist.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorSecurityConfigOptions.php

3 lines

settings/

panel/

PhabricatorExternalEditorSettingsPanel.php

1 line

Diff 50500

View Options

src/applications/config/option/PhabricatorSecurityConfigOptions.php