Page MenuHomePhabricator

Add "--browse" to "arc upload" and update behavior, particularly "--json"
ClosedPublic

Authored by epriestley on May 1 2020, 3:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 7:26 PM
Unknown Object (File)
Sun, Apr 28, 6:46 PM
Unknown Object (File)
Fri, Apr 26, 11:26 PM
Unknown Object (File)
Wed, Apr 24, 10:45 PM
Unknown Object (File)
Tue, Apr 2, 7:21 PM
Unknown Object (File)
Tue, Apr 2, 8:24 AM
Unknown Object (File)
Mar 30 2024, 12:23 AM
Unknown Object (File)
Feb 1 2024, 8:40 PM
Subscribers
None

Details

Summary

Ref T13528. Provide a "--browse" flag to open files after they are uploaded.

Update the code to use modern query strategies.

This impacts the output of "--json", which was just raw "file.info" output before and could not represent the same path being passed several times (arc upload X X).

Test Plan

Ran arc upload with --browse and --json.

Diff Detail

Repository
rARC Arcanist
Branch
browse1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistUploadWorkflow.php:75XHP16TODO Comment
Advicesrc/workflow/ArcanistWorkflow.php:2425XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24301
Build 33479: Run Core Tests
Build 33478: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 4:13 PM
This revision was automatically updated to reflect the committed changes.