Page MenuHomePhabricator

Add "--browse" to "arc upload" and update behavior, particularly "--json"
ClosedPublic

Authored by epriestley on May 1 2020, 3:06 PM.
Tags
None
Referenced Files
F16793619: D21202.id50496.diff
Wed, Jun 18, 3:37 AM
F16706087: D21202.id50486.diff
Tue, Jun 17, 5:06 PM
F16643402: D21202.id.diff
Tue, Jun 17, 10:50 AM
Unknown Object (File)
Tue, Jun 17, 12:45 AM
Unknown Object (File)
Mon, Jun 16, 6:54 PM
Unknown Object (File)
May 10 2025, 8:44 AM
Unknown Object (File)
May 9 2025, 10:21 PM
Unknown Object (File)
May 6 2025, 1:26 PM
Subscribers
None

Details

Summary

Ref T13528. Provide a "--browse" flag to open files after they are uploaded.

Update the code to use modern query strategies.

This impacts the output of "--json", which was just raw "file.info" output before and could not represent the same path being passed several times (arc upload X X).

Test Plan

Ran arc upload with --browse and --json.

Diff Detail

Repository
rARC Arcanist
Branch
browse1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistUploadWorkflow.php:75XHP16TODO Comment
Advicesrc/workflow/ArcanistWorkflow.php:2425XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24301
Build 33479: Run Core Tests
Build 33478: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 4:13 PM
This revision was automatically updated to reflect the committed changes.