Differential D21194

Stabilize fatals when a build has a build plan the viewer can't see because of policy restrictions
ClosedPublic
Actions

Authored by epriestley on Apr 30 2020, 2:47 PM.

Tags

None

Referenced Files

	F14895445: D21194.id50476.diff
	Sun, Feb 9, 9:10 AM

	F14895444: D21194.id50475.diff
	Sun, Feb 9, 9:10 AM

	F14895443: D21194.id.diff
	Sun, Feb 9, 9:10 AM

	F14895442: D21194.diff
	Sun, Feb 9, 9:10 AM

	Unknown Object (File)
	Sat, Jan 25, 7:26 AM

	Unknown Object (File)
	Sat, Jan 25, 7:26 AM

	Unknown Object (File)
	Sat, Jan 25, 7:26 AM

	Unknown Object (File)
	Sat, Jan 25, 7:25 AM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13526: Error raised when "HarbormasterBuildPlanBehavior->getPlanOption()" is reachable with no plan
Commits: rP4a7a66975613: (stable) Stabilize fatals when a build has a build plan the viewer can't see…
rP304467feb2ae: Stabilize fatals when a build has a build plan the viewer can't see because of…

Summary

Ref T13526. Currently, if a build plan is restricted, viewers may fatal when trying to view related builds.

The old behavior allowed them to see the build even if they can not see the build plan. This is sort of incoherent, but try to stabilize things before fixing this.

Test Plan

This is a muddy change.

Created a build with a build plan that Alice can't see.
As Alice, viewed the build page (restricted before, restricted after); the buildable page (fatal before, works after).
Also viewed a revision page (works before and after, but user-reported fatal).

Diff Detail

Repository

Branch

build1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24290
Build 33460: Run Core Tests
Build 33459: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 30 2020, 2:47 PM

Owners added a subscriber: Restricted Owners Package.Apr 30 2020, 2:47 PM

Harbormaster completed remote builds in B24290: Diff 50475.Apr 30 2020, 2:49 PM

epriestley requested review of this revision.Apr 30 2020, 2:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 30 2020, 2:57 PM

Closed by commit rP304467feb2ae: Stabilize fatals when a build has a build plan the viewer can't see because of… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP304467feb2ae: Stabilize fatals when a build has a build plan the viewer can't see because of….

epriestley added a commit: rP4a7a66975613: (stable) Stabilize fatals when a build has a build plan the viewer can't see….Apr 30 2020, 3:00 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialRevision.php

15 lines

harbormaster/

storage/

build/

HarbormasterBuild.php

16 lines

Diff 50475

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...