Differential D21189

Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
ClosedPublic
Actions

Authored by epriestley on Apr 29 2020, 9:45 PM.

Tags

None

Referenced Files

	F15479351: D21189.diff
	Tue, Apr 8, 6:32 AM

	F15458241: D21189.id50458.diff
	Sun, Mar 30, 10:06 PM

	F15455536: D21189.diff
	Sun, Mar 30, 3:00 AM

	F15449923: D21189.id.diff
	Fri, Mar 28, 12:53 PM

	F15444680: D21189.id50457.diff
	Thu, Mar 27, 10:42 AM

	F15437447: D21189.diff
	Tue, Mar 25, 7:27 PM

	F15437192: D21189.diff
	Tue, Mar 25, 6:10 PM

	F15427365: D21189.id.diff
	Sun, Mar 23, 2:01 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13519: Support collapsing folders in the diff paths panel
Commits: rPf892a5858d75: (stable) Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
rP186a12ef7f2a: Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"

Summary

Ref T13519. See https://discourse.phabricator-community.org/t/error-call-to-undefined-method-differentialchangesetquery-withphids/3816/.

Changesets do not have PHIDs, and the Query has no "withPHIDs()" method. The keys in the viewstate storage are (usually) IDs.

Test Plan

On a revision with Diff 1 and Diff 2 affecting the same file:
- Viewed Diff 1.
- Hid file A.
- Viewed Diff 2.
Before patch: exception about call to "withPHIDs()", which does not exist for ChangesetQuery.
After patch: no exception. Also, file actually unhid, which is the correct behavior!

Diff Detail

Repository

Branch

hide1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24276
Build 33441: Run Core Tests
Build 33440: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 29 2020, 9:45 PM

Harbormaster completed remote builds in B24276: Diff 50457.Apr 29 2020, 9:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 29 2020, 9:47 PM

epriestley requested review of this revision.

Closed by commit rP186a12ef7f2a: Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP186a12ef7f2a: Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()".

epriestley added a commit: rPf892a5858d75: (stable) Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()".

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

diff/

viewstate/

PhabricatorChangesetViewStateEngine.php

4 lines

Diff 50457

src/infrastructure/diff/viewstate/PhabricatorChangesetViewStateEngine.php

Loading...