Page MenuHomePhabricator

Update the diff table of contents to use hierarchical views and edit distance renames
ClosedPublic

Authored by epriestley on Apr 28 2020, 7:23 PM.
Tags
None
Referenced Files
F14895405: D21183.id50446.diff
Sun, Feb 9, 9:08 AM
F14895404: D21183.id50445.diff
Sun, Feb 9, 9:08 AM
F14895403: D21183.id.diff
Sun, Feb 9, 9:08 AM
Unknown Object (File)
Sat, Jan 25, 7:23 AM
Unknown Object (File)
Sat, Jan 25, 7:23 AM
Unknown Object (File)
Sat, Jan 25, 7:23 AM
Unknown Object (File)
Tue, Jan 21, 9:33 AM
Unknown Object (File)
Jan 6 2025, 8:30 PM
Subscribers
None

Details

Summary

Ref T13520. Generally, make the table of contents look and more like the paths panel:

  • Show a hierarchy, with compression for single-sibling children.
  • Use the same icons, instead of "M D" and "(img)" stuff.
  • Use EditDistanceMatrix to do a piece-by-piece diff of paths changes.
  • Show path changes within the path list.

I'm not entirely sold on this, but it was complicated to write and I've never heard the term "sunk cost fallacy". I think this is mostly a net improvement, but may need some adjustments and followup.

Test Plan

Viewed various changes in Differential and Diffusion, saw a more usable table of contents.

Diff Detail

Repository
rP Phabricator
Branch
toc1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php:134XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24264
Build 33420: Run Core Tests
Build 33419: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 7:27 PM
This revision was automatically updated to reflect the committed changes.