Differential D21181

Fix an issue with "Auditors:" where an edge edit was used as a PHID list
ClosedPublic
Actions

Authored by epriestley on Apr 28 2020, 12:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 7, 5:41 AM

	Unknown Object (File)
	Mon, May 6, 7:58 AM

	Unknown Object (File)
	Fri, May 3, 2:50 PM

	Unknown Object (File)
	Fri, May 3, 3:27 AM

	Unknown Object (File)
	Mon, Apr 29, 2:59 PM

	Unknown Object (File)
	Fri, Apr 26, 3:40 PM

	Unknown Object (File)
	Wed, Apr 24, 10:52 PM

	Unknown Object (File)
	Mar 31 2024, 5:42 PM

View All 82 Files

Subscribers

None

Details

Reviewers: None
Commits: rP055d8b272826: (stable) Fix an issue with "Auditors:" where an edge edit was used as a PHID…
rPa7b2327c34ac: Fix an issue with "Auditors:" where an edge edit was used as a PHID list

Summary

See https://discourse.phabricator-community.org/t/runtimeexception-during-import-of-commit/3801. When importing commits with "Auditors:", a raw transaction new value (with an edge edit map using a "+" key) may be passed as an unmentionable PHID list.

Instead, pass an actual PHID list.

Test Plan

Pushed a commit with "Auditors: duck".
Ran daemons.
- Before patch: umentionable PHID exception.
- After patch: clean commit import.
Verified "duck" was added as an auditor.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 28 2020, 12:46 PM

Harbormaster completed remote builds in B24259: Diff 50440.Apr 28 2020, 12:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 12:47 PM

epriestley requested review of this revision.

Closed by commit rPa7b2327c34ac: Fix an issue with "Auditors:" where an edge edit was used as a PHID list (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa7b2327c34ac: Fix an issue with "Auditors:" where an edge edit was used as a PHID list.

epriestley added a commit: rP055d8b272826: (stable) Fix an issue with "Auditors:" where an edge edit was used as a PHID….Apr 28 2020, 12:50 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

25 lines

Diff 50441

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...