Differential D21181

Fix an issue with "Auditors:" where an edge edit was used as a PHID list
ClosedPublic
Actions

Authored by epriestley on Apr 28 2020, 12:46 PM.

Tags

None

Referenced Files

	F19815225: D21181.diff
	Wed, Mar 4, 7:13 PM

	F19801470: D21181.diff
	Sat, Feb 28, 11:47 PM

	F19800998: D21181.id.diff
	Sat, Feb 28, 8:00 PM

	F19016644: D21181.id.diff
	Nov 23 2025, 4:48 AM

	F18952770: D21181.diff
	Nov 12 2025, 6:29 AM

	F18841748: D21181.id50440.diff
	Oct 28 2025, 11:01 AM

	F18830409: D21181.diff
	Oct 25 2025, 6:41 AM

	F18823682: D21181.diff
	Oct 23 2025, 12:56 PM

Subscribers

None

Details

Reviewers: None
Commits: rP055d8b272826: (stable) Fix an issue with "Auditors:" where an edge edit was used as a PHID…
rPa7b2327c34ac: Fix an issue with "Auditors:" where an edge edit was used as a PHID list

Summary

See https://discourse.phabricator-community.org/t/runtimeexception-during-import-of-commit/3801. When importing commits with "Auditors:", a raw transaction new value (with an edge edit map using a "+" key) may be passed as an unmentionable PHID list.

Instead, pass an actual PHID list.

Test Plan

Pushed a commit with "Auditors: duck".
Ran daemons.
- Before patch: umentionable PHID exception.
- After patch: clean commit import.
Verified "duck" was added as an auditor.

Diff Detail

Repository

Branch

audit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24259
Build 33413: Run Core Tests
Build 33412: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 28 2020, 12:46 PM

Harbormaster completed remote builds in B24259: Diff 50440.Apr 28 2020, 12:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 12:47 PM

epriestley requested review of this revision.

Closed by commit rPa7b2327c34ac: Fix an issue with "Auditors:" where an edge edit was used as a PHID list (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa7b2327c34ac: Fix an issue with "Auditors:" where an edge edit was used as a PHID list.

epriestley added a commit: rP055d8b272826: (stable) Fix an issue with "Auditors:" where an edge edit was used as a PHID….Apr 28 2020, 12:50 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

25 lines

Diff 50440

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...