Page MenuHomePhabricator

For changesets that affect binaries, use the new binary file content hash as an effect hash
ClosedPublic

Authored by epriestley on Apr 27 2020, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 6:09 PM
Unknown Object (File)
Oct 14 2024, 6:19 PM
Unknown Object (File)
Oct 13 2024, 5:08 AM
Unknown Object (File)
Oct 9 2024, 1:23 PM
Unknown Object (File)
Oct 5 2024, 12:30 PM
Unknown Object (File)
Oct 1 2024, 3:16 PM
Unknown Object (File)
Sep 24 2024, 4:36 PM
Unknown Object (File)
Aug 25 2024, 4:56 AM
Subscribers
None

Details

Summary

Ref T13522. When changesets update an image, we currently compute no effect hash. A content hash of the image (or other binary file) is a reasonable effect hash, and enalbes effect-hash-based behavior, including hiding files in intradiffs.

Test Plan
  • Created a revision affecting cat.png and quack.txt (currently, there must be 2+ changesets to trigger the hide logic).
  • Updated it with the exact same changes.
  • Viewed revision:
    • Saw the image renderered in the interdiff.
  • Applied patch.
  • Ran bin/differential rebuild-changesets ....
  • Viewed revision:
    • Saw both changesets collapse as unchanged.

Diff Detail

Repository
rP Phabricator
Branch
file1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/storage/DifferentialDiff.php:235XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24240
Build 33387: Run Core Tests
Build 33386: arc lint + arc unit