Ref T13522. When changesets update an image, we currently compute no effect hash. A content hash of the image (or other binary file) is a reasonable effect hash, and enalbes effect-hash-based behavior, including hiding files in intradiffs.
Details
Details
- Created a revision affecting cat.png and quack.txt (currently, there must be 2+ changesets to trigger the hide logic).
- Updated it with the exact same changes.
- Viewed revision:
- Saw the image renderered in the interdiff.
- Applied patch.
- Ran bin/differential rebuild-changesets ....
- Viewed revision:
- Saw both changesets collapse as unchanged.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- file1
- Lint
Lint Passed Severity Location Code Message Advice src/applications/differential/storage/DifferentialDiff.php:235 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 24240 Build 33387: Run Core Tests Build 33386: arc lint + arc unit