Page MenuHomePhabricator

For changesets that affect binaries, use the new binary file content hash as an effect hash
ClosedPublic

Authored by epriestley on Apr 27 2020, 3:29 PM.
Tags
None
Referenced Files
F13041382: D21174.diff
Tue, Apr 16, 8:13 PM
Unknown Object (File)
Fri, Apr 12, 12:41 AM
Unknown Object (File)
Thu, Apr 11, 7:58 AM
Unknown Object (File)
Thu, Mar 28, 3:36 PM
Unknown Object (File)
Feb 22 2024, 1:13 PM
Unknown Object (File)
Jan 25 2024, 2:22 AM
Unknown Object (File)
Jan 5 2024, 1:25 PM
Unknown Object (File)
Dec 30 2023, 6:14 PM
Subscribers
None

Details

Summary

Ref T13522. When changesets update an image, we currently compute no effect hash. A content hash of the image (or other binary file) is a reasonable effect hash, and enalbes effect-hash-based behavior, including hiding files in intradiffs.

Test Plan
  • Created a revision affecting cat.png and quack.txt (currently, there must be 2+ changesets to trigger the hide logic).
  • Updated it with the exact same changes.
  • Viewed revision:
    • Saw the image renderered in the interdiff.
  • Applied patch.
  • Ran bin/differential rebuild-changesets ....
  • Viewed revision:
    • Saw both changesets collapse as unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable