Page MenuHomePhabricator

Make "arc <workflow> --help" work again for workflows which haven't updated yet
ClosedPublic

Authored by epriestley on Apr 25 2020, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 9:06 AM
Unknown Object (File)
Wed, Feb 5, 12:49 PM
Unknown Object (File)
Wed, Jan 29, 12:42 AM
Unknown Object (File)
Sat, Jan 25, 7:20 AM
Unknown Object (File)
Fri, Jan 24, 12:13 PM
Unknown Object (File)
Thu, Jan 23, 10:59 PM
Unknown Object (File)
Sun, Jan 19, 10:12 AM
Unknown Object (File)
Fri, Jan 17, 10:21 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/help-is-no-longer-present-for-arc-subcommands-in-todays-stable/3786.

The "--help" flag ends up falling through to the old "arcanist.php", where it becomes lost. Catch it earlier so "arc diff --help" prints diff help, for instance.

Test Plan

Ran arc help diff, arc diff --help, arc --help diff, and similar commands for updated workflows; got help.

Diff Detail

Repository
rARC Arcanist
Branch
help1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24220
Build 33359: Run Core Tests
Build 33358: arc lint + arc unit