Page MenuHomePhabricator

Make "arc <workflow> --help" work again for workflows which haven't updated yet
ClosedPublic

Authored by epriestley on Apr 25 2020, 3:54 PM.
Tags
None
Referenced Files
F15418963: D21168.id50401.diff
Fri, Mar 21, 2:44 AM
F15391416: D21168.id50401.diff
Sat, Mar 15, 9:47 AM
F15337392: D21168.diff
Sun, Mar 9, 5:39 AM
F15315948: D21168.id50402.diff
Thu, Mar 6, 6:16 PM
F15315937: D21168.id50401.diff
Thu, Mar 6, 6:16 PM
F15315936: D21168.id.diff
Thu, Mar 6, 6:16 PM
F15315933: D21168.diff
Thu, Mar 6, 6:16 PM
F15302829: D21168.id50401.diff
Wed, Mar 5, 10:39 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/help-is-no-longer-present-for-arc-subcommands-in-todays-stable/3786.

The "--help" flag ends up falling through to the old "arcanist.php", where it becomes lost. Catch it earlier so "arc diff --help" prints diff help, for instance.

Test Plan

Ran arc help diff, arc diff --help, arc --help diff, and similar commands for updated workflows; got help.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable